Switch from cuda-memcheck to compute-sanitizer #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After OS upgrade on CI system, cuda-memcheck fails to detect the known errors in badcuda.cpp, which are based on examples from the nvidia docs: https://docs.nvidia.com/cuda/archive/11.4.1/cuda-memcheck/index.html#example-use-of-memcheck It isn't clear why this is the case, but since cuda-memcheck is deprecated in favor of compute-sanitizer in later versions anyway, I am switching to compute-sanitizer. It successfully detects errors in badcuda.
|
PR also now includes a small update the the gitlab CI control, which was necessary because of changes to GitLab's runner authentication-token framework. |
For some reason that I don't understand, lomach-flow.test 5 (i.e., "verify consistent serialized restart for Tomboulides with lid-driven cavity with 2 mpi ranks") consistently fails on one of our testing systems that uses flux b/c it thinks that the restart file written by the solver does not exist when the test script attempts to mv the file (the mv on line 133 of this version). This commit, which adds some steps between the tps solve and the mv, appears to avoid the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After OS upgrade on CI system, cuda-memcheck fails to detect the known errors in badcuda.cpp, which are based on examples from the nvidia docs:
https://docs.nvidia.com/cuda/archive/11.4.1/cuda-memcheck/index.html#example-use-of-memcheck
It isn't clear why this is the case, but since cuda-memcheck is deprecated in favor of compute-sanitizer in later versions anyway, I am switching to compute-sanitizer. It successfully detects errors in badcuda.